Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Triggering the unsaved changes AYS dialog in the editor loses <- Back button history #4509

Closed
ryanboren opened this issue Apr 4, 2016 · 4 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Navigation [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ryanboren
Copy link
Contributor

Triggering an AYS in the editor loses <- Back button history.

I trigger the unsaved changed AYS (Are You Sure?) dialog often when creating drafts. I’ll jump in to the editor capture a thought to work through later, maybe toss a screenshot up, and then get right back out. Autosave is usually too slow and I invoke the AYS, which seems to stomp <- Back button history. This disrupts my draft flow.

Steps to reproduce

  1. Starting at URL: /posts/drafts
  2. Edit a draft.
  3. Make changes and then hit the editor's <- Back button before the changes save.
  4. Notice that unsaved changes AYS dialog pop ups.
  5. Cancel the dialog
  6. Wait for the draft to autosave
  7. Click/tap <- Back
  8. Notice that you are returned to /posts/ instead of /posts/drafts, losing your origin

What I expected

I expected to return to /posts/drafts/, where I started. If the AYS dialog is not triggered, <- Back correctly returns to /posts/drafts/.

What happened instead

<-Back returns to /posts/ instead of /drafts/.

Browser / OS version

Macnchrome, latest
iPhone +, latest

Screenshot / Video

Flow starting from /drafts and following the steps to reproduce. Note that the start and finish are different.

screen shot 2016-04-04 at 12 46 20 pm
screen shot 2016-04-04 at 12 46 34 pm
screen shot 2016-04-04 at 12 46 43 pm
screen shot 2016-04-04 at 12 46 54 pm
screen shot 2016-04-04 at 12 47 03 pm

@ryanboren ryanboren added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Post/Page Editor The editor for editing posts and pages. labels Apr 4, 2016
@ryanboren
Copy link
Contributor Author

Manually clicking/tapping Update also loses history.

@ryanboren
Copy link
Contributor Author

After triggering AYS and clicking through, this results. Macnchrome.

image

@ryanboren
Copy link
Contributor Author

Still happens. If you're on a wide screen where Drafts pops out to its own column, narrow your browser until Drafts is in the filter bar.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Navigation [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants