FSE: Contextual Tips issues with Block Directory

[WunderBart]

FSE’s Contextual Tips seem to be working differently since the v8.4.0 introduced the Block Directory. I noticed two things:

1. Inline inserter doesn't show the Contextual Tips anymore

This happens on both, Simple and Atomic sites.

2. Main inserter shows the tips at the bottom, instead of the top

This happens on Simple sites only where we had to disable the Block Directory. On Atomic sites, they’re rendered at the top.

Simple site, Contextual Tip at the bottom:

Atomic site, Contextual Tip at the top:

Context: p7DVsv-8X4-p2#comment-30041
Related: r210682-wpcom

[jeryj]

Main inserter shows the tips at the bottom, instead of the top

This is due to WPcom adding a fill on the same __experimentalInserterMenuExtension slot. Work in progress at D47125-code.

[jeryj]

Inline inserter doesn't show the Contextual Tips anymore

The inline inserter is a new component called the <QuickInserter />, added in this PR: WordPress/gutenberg#22789

The Contextual Tips uses the <__experimentalInserterMenuExtension.Slot />. This Slot isn't present on the <QuickInserter />, and I don't see any slots available on it.

More context: p7DVsv-8X4-p2#comment-30101

[davemart-in]

@WunderBart I'm sending this one back to your team. @jeryj did some investigation and it looks like we'll need to create a new Slot in Gutenberg core to fix this.

[sirreal]

We could give our empty results handler a lower priority so it's enqueued first, but we have to go into negative values because the current contextual enqueuing action has the extremely low value of 0 as opposed to the default 10:

wp-calypso/apps/full-site-editing/full-site-editing-plugin/block-inserter-modifications/index.php

Line 74 in 13f4c55

add_action( 'enqueue_block_editor_assets', __NAMESPACE__ . '\enqueue_block_inserter_modifications', 0 );

@jeryj Do you know if there's a reason for that to have such a low priority?

See D47395-code (sets priority -1) for an alternative to D47125-code.

[sirreal]

See D47395-code (sets priority -1) for an alternative to D47125-code.

I got this backwards and have updated D47395-code accordingly.

[sirreal]

Fixed by r211559-wpcom

[sirreal]

@davemart-in @jeryj I closed this based on contextual tips positioning in the main inserter (fixed by r211559-wpcom). Did this need to stay open to track missing contextual tips in the quick inserter?

[davemart-in]

Nope, happy to close this out if it's fixed. Thanks @sirreal!