Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSE: conditional block removal #37044

Closed
vindl opened this issue Oct 24, 2019 · 5 comments
Closed

FSE: conditional block removal #37044

vindl opened this issue Oct 24, 2019 · 5 comments
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Task

Comments

@vindl
Copy link
Member

vindl commented Oct 24, 2019 •
edited
Loading

We need to figure out if it's possibly to conditionally disable block removal with existing Block API, so we can implement the proposed Footer Credit block paywall.

If there are no extension points in Core for this, we should start communicating with Core folks on the best way to introduce it and start a PR for doing that.

For context and related work you can check out this parent issue: https://github.com/Automattic/Dotcom-roadmap/issues/50.
@vindl vindl added [Pri] High Address as soon as possible after BLOCKER issues [Type] Task [Goal] Full Site Editing [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. labels Oct 24, 2019
This was referenced Oct 24, 2019
Closed
Closed
@noahtallen
Copy link
Contributor

This feature does not appear to exist yet: WordPress/gutenberg#16364

@noahtallen
Copy link
Contributor

I have a Gutenberg contribution here which adds this to Gutenberg WordPress/gutenberg#18118

@noahtallen
Copy link
Contributor

The required block message likely doesn't exist in Gutenberg either.

@noahtallen noahtallen removed their assignment Dec 16, 2019
@noahtallen
Copy link
Contributor

Removed myself since we aren't actively working on this at the moment.

@davipontesblog
Copy link
Contributor

Closing in favor of the core WordPress FSE implementation in dotCom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Goal] Full Site Editing [Pri] High Address as soon as possible after BLOCKER issues [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vindl @noahtallen @davipontesblog