Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Header bar has duplicate site information #23343

Closed
kellychoffman opened this issue Mar 15, 2018 · 3 comments
Closed

Store: Header bar has duplicate site information #23343

kellychoffman opened this issue Mar 15, 2018 · 3 comments
Assignees
Labels
Store [Type] Bug When a feature is broken and / or not performing as intended

Comments

@kellychoffman
Copy link
Member

kellychoffman commented Mar 15, 2018

There were some much needed and appreciated changes to the mobile header. #22541 These also made changes to the larger screen views, which caused duplicate site info:

screen shot 2018-03-15 at 12 49 55 pm

Our original header designed purposely diverged from the rest of calypso given the nature of Store.

Options to fix:

  • Only apply mobile changes to small screen (revert changes made to the large screen)
  • @justinshreve suggests: Change header above nav to read "Store"
  • Borrow @shaunandrews's designs
  • Other ideas? cc @jameskoster
@brbrr brbrr added the [Type] Bug When a feature is broken and / or not performing as intended label Mar 16, 2018
@jameskoster
Copy link
Contributor

The only other option I could think of would be to combine the site link with the title/breadcrumb area;

combined

But that doesn't disrupts the link between content / navigation so not really ideal.

Only apply mobile changes to small screen (revert changes made to the large screen)

That seems like the cleanest solution design-wise.

@shaunandrews
Copy link
Contributor

FWIW, I think what you mocked up, @jameskoster, is really nice. It reminds me of the editor's "ground control" toolbar.

The store currently has a "sticky" header for that primary action button, how would your mockup work with scrolling? Would the whole bar be sticky?

--

One note, not totally relevant: Can we switch to a chevron rather than the back arrow? That's what we're using to indicate a sidebar item has a second-level of navigation:

screen shot 2018-03-19 at 10 33 19 am

@jameskoster
Copy link
Contributor

The store currently has a "sticky" header for that primary action button, how would your mockup work with scrolling? Would the whole bar be sticky?

The whole bar is sticky anyway, so it would work fine in that regard I think.

One note, not totally relevant: Can we switch to a chevron rather than the back arrow? That's what we're using to indicate a sidebar item has a second-level of navigation:

Yeah we can definitely address that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Store [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants