Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: preview not working on mobile Safari #2129

Closed
designsimply opened this issue Jan 5, 2016 · 1 comment
Closed

Themes: preview not working on mobile Safari #2129

designsimply opened this issue Jan 5, 2016 · 1 comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@designsimply
Copy link
Contributor

Raised by @seear

To Reproduce

  1. Visit wordpress.com/design on iPhone or Safari->Develop->Responsive Design in iPhone mode
  2. Tap on a theme screenshot. Note that the preview does not appear.

Found on my phone, and OS X Safari responsive mode shows same behavior:

mob_safari_preview

.web-preview__frame height is 0 for some reason.

Preview works in iPhone editor, but the phone/tablet/desktop switcher is obscured by the (master?)bar at the top.

Comment from @ehg

Changing .web-preview__frame to have a min-height: 100% fixed this for me. Not sure how wise that is.

Reply from @seear

It seems to be some weird interaction with the float: right property on the .main element, because dropping that causes this the preview to start working. This information strikes me as disheartening rather than enlightening.

min-height: 100% seems to me to be a decent solution in the circumstances.

Notes from @lancewillett

Still happening — not just Mobile Safari but any small screen view, like using Firefox desktop browser and changing to small screen size with Cmd-Shift-M.

mobile-safari-no-preview

Relates to 7657-wpcom in that we'd like to send mobile preview requests directly to site preview and not to Customizer.

@designsimply designsimply added [Type] Bug When a feature is broken and / or not performing as intended [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] High Address as soon as possible after BLOCKER issues labels Jan 5, 2016
@ehg ehg modified the milestones: Themes: Future, Themes: Showcase M3-LoggedOut Jan 8, 2016
@folletto folletto modified the milestones: Themes: Maintenance, Themes: Future Jan 21, 2016
@lancewillett
Copy link
Contributor

Testing this again today: it's working as expected now. :)

Testing with https://wpcalypso.wordpress.com/design/lancetest23.wordpress.com

  1. On a small screen device, go to My Sites
  2. Click Themes
  3. Click a theme screenshot
  4. The demo site preview loads correctly.

img_4710

iPhone 6+, iOS 9.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants