Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Media: support custom media sizes defined by site specific code #1574

Closed
designsimply opened this issue Dec 14, 2015 · 2 comments
Closed
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@designsimply
Copy link
Contributor

Raised by @jkudish

The Editor should support custom media sizes defined by sites (via add_image_size)

Before we can add custom thumbnail sizes in the Calypso editor, support for providing this information will need to be added to the REST API. (478-gh-io)

@designsimply designsimply added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. labels Dec 14, 2015
@designsimply designsimply added this to the Editor: Future milestone Dec 14, 2015
@designsimply designsimply changed the title Editor: Media: support custom sizes defined by site specific code Editor: Media: support custom media sizes defined by site specific code Dec 21, 2017
@designsimply
Copy link
Contributor Author

designsimply commented Dec 21, 2017

#bug-scrub #pre-gutenburg-bug-purge

Tested and confirmed that the Calypso Editor still does not support custom media sizes using the following steps:

  1. Go to wp-admin > Settings > Media.
  2. Update "Thumbnail size" to 50 x 50.
  3. Go to Posts > Add New, select an image, change the size to Thumbnail in the Attachment Display Settings, and click "Insert into post."
  4. Go to My Sites > Add and select (+) Add > Media in the editor toolbar.
  5. Select and insert an image, click the image, and click the "-" button in the image toolbar until the image can no longer get any smaller.

Result: the image inserted using the wp-admin editor respects the custom media thumbnail size set in step 2 while the image inserted using the Calypso editor does not.

screen shot 2017-12-21 at thu dec 21 2 58 02 pm

Seen at https://wordpress.com/post/design5279.wordpress.com/11665 using Firefox 57.0.1 on macOS 10.13.2.

screen shot 2017-12-21 at thu dec 21 2 57 49 pm

Seen at https://design5279.wordpress.com/wp-admin/post-new.php using Firefox 57.0.1 on macOS 10.13.2.

@creativecoder
Copy link
Contributor

With the Calypso editor deprecated, I don't think this issue is relevant any longer, but please feel free to re-open it if that's incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

2 participants