Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Editor: needs to work on jetpack #11241

Closed
rralian opened this issue Feb 7, 2017 · 4 comments
Closed

Image Editor: needs to work on jetpack #11241

rralian opened this issue Feb 7, 2017 · 4 comments
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Pri] High Address as soon as possible after BLOCKER issues [Type] Task

Comments

@rralian
Copy link
Contributor

rralian commented Feb 7, 2017

this is a blocker level issue

@apeatling apeatling added the [Pri] BLOCKER Requires immediate attention. label Feb 7, 2017
@aduth
Copy link
Contributor

aduth commented Feb 7, 2017

Is there context for this? We use the image editor for Jetpack sites in the site icon flow without issue. The only gotcha is that it requires Photon to be enabled on the site. In some discussion with @gwwar, I pointed out that we may not need to be considering this at all (i.e. can't imagine why it wouldn't work with Photon disabled).

@gwwar
Copy link
Contributor

gwwar commented Feb 7, 2017

@aduth The media modal uses a new edit endpoint ( edit vs copy workflow). We need to spin up a Jetpack PR to get back to parity.

@aduth
Copy link
Contributor

aduth commented Feb 7, 2017

Oh right, sorry, forgot about the separate endpoint revisions. (This doesn't affect site icon because we upload new media, not replace existing)

@lancewillett lancewillett added [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Type] Task labels Feb 13, 2017
@lancewillett lancewillett added [Pri] High Address as soon as possible after BLOCKER issues and removed [Pri] BLOCKER Requires immediate attention. labels Jun 19, 2017
@rralian
Copy link
Contributor Author

rralian commented Jun 20, 2017

This has been addressed, I've tested using my own Jetpack test site and I'm successfully able to edit images.

@rralian rralian closed this as completed Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Pri] High Address as soon as possible after BLOCKER issues [Type] Task
Projects
None yet
Development

No branches or pull requests

5 participants