Image support

[tj]

best to mirror the DOM api with onload etc

[ghost]

+1 for supporting drawImage() and getData()

At the moment to read image data into our game server (heightmaps for generating terrain) we're delegating the canvas work out to a "worker" client but this is less than optimal and severely increases the complexity of the task.

Alternatively, if anyone knows of a simple way to sample an image (read pixel colors) in node.js, we'd appreciate the advice :)

[tj]

added Image / drawImage()

[ghost]

playing with this now ^w^

[tj]

let me know if you come across bugs, there are likely a few :)

[ghost]

is drawImage supposed to work?

here's a screenshot of the visual tests running in chrome...

http://awesomescreenshot.com/0303k2kfa

i tried webkit, firefox etc just in case (although I'm convinced the browser shouldn't make a difference)

code ran on server-side is...

function (ctx, done){
  var img = new Image;
  img.onload = function(){
    ctx.drawImage(img, 0, 0);
    done();
  };
  img.src = '/Users/pyrotechnick/node-canvas/test/public/state.png';
}

so your path-replacement seems to have worked correctly. and yes this file (state.png) definitely exists

btw this is cairo 1.8.10

[ghost]

okay i've just found this...

#if CAIRO_VERSION_MINOR < 10
  return ThrowException(Exception::Error(String::New("drawImage() needs cairo >= 1.10.0")));
#else

i used homebrew to install cairo and it seems to only have a recipe to 1.8.10

installing manually now...

[tj]

yeah, homebrew sucks lol. I would like to have a backport for older versions

[ghost]

hell yeah. it's all good with cairo 1.10.0

[ghost]

i'll patch homebrew if i can. the warning

#if CAIRO_VERSION_MINOR < 10
  return ThrowException(Exception::Error(String::New("drawImage() needs cairo >= 1.10.0")));
#else

isn't being triggered in my environment. best warn people another way perhaps. or make a note of it in the README

[tj]

hm, weird... should work fine, I will have to revert my cairo version and try stuff out

[ghost]

it should come up in console at compile time right? this was my output with cairo 1.8.10

node-canvas pyrotechnick$ node-waf configure build
Checking for program g++ or c++          : /usr/bin/g++ 
Checking for program cpp                 : /usr/bin/cpp 
Checking for program ar                  : /usr/bin/ar 
Checking for program ranlib              : /usr/bin/ranlib 
Checking for g++                         : ok  
Checking for node path                   : ok /usr/local/lib/node 
Checking for node prefix                 : ok /usr/local 
Checking for cairo                       : yes 
'configure' finished successfully (0.573s)
Waf: Entering directory `/Users/pyrotechnick/node-canvas/build'
[1/8] cxx: src/Canvas.cc -> build/default/src/Canvas_1.o
[2/8] cxx: src/CanvasGradient.cc -> build/default/src/CanvasGradient_1.o
[3/8] cxx: src/CanvasRenderingContext2d.cc -> build/default/src/CanvasRenderingContext2d_1.o
[4/8] cxx: src/Image.cc -> build/default/src/Image_1.o
../src/Image.cc:169: warning: ‘int EIO_Load(eio_req*)’ defined but not used
../src/Image.cc:180: warning: ‘int EIO_AfterLoad(eio_req*)’ defined but not used
[6/8] cxx: src/init.cc -> build/default/src/init_1.o
[5/8] cxx: src/ImageData.cc -> build/default/src/ImageData_1.o
[7/8] cxx: src/PixelArray.cc -> build/default/src/PixelArray_1.o
[8/8] cxx_link: build/default/src/Canvas_1.o build/default/src/CanvasGradient_1.o build/default/src/CanvasRenderingContext2d_1.o build/default/src/Image_1.o build/default/src/ImageData_1.o build/default/src/init_1.o build/default/src/PixelArray_1.o -> build/default/canvas.node
Waf: Leaving directory `/Users/pyrotechnick/node-canvas/build'
'build' finished successfully (3.145s)

[tj]

Not compile time no