-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement arcTo() #11
Comments
I have an initial version of this working. It's a lot of math. The kind of work that makes me think I've done it wrong, but then I remember that this is why there aren't that many finished graphics libraries... The only changes to my master branch are for I borrowed It might be worth borrowing from http://philip.html5.org/demos/canvas/arcto-inf.html too, which should look like http://philip.html5.org/demos/canvas/arcto-inf.png |
wicked thanks man, I will take a look and merge shortly. |
I'm porting that other demo now, FYI. |
OK, they all fail :) Better hold off on that merge! (Also I just realized I overwrote my previous test... I'll be in touch) |
ahaha k :) let me know |
OK, I think I got a bit carried away with one of my tests. I'm calculating the control points correctly but I'm not catching some of the edge cases that the browser versions handle. I've got a test for triangle insideness in there which doesn't seem to be necessary, and something else needs to trigger that case instead. Here's how Webkit does it with Cairo: I'll have to put this down for now. Sorry for false alarm! |
Added arcTo(). Closed by ea4b13e |
went with a slightly modified version of the webkit one, thanks for pointing it out |
Awesome, glad you got it working! |
No description provided.
The text was updated successfully, but these errors were encountered: