Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API: Plugins endpoint breaks characters in plugin action links #7127

Closed
tyxla opened this issue May 5, 2017 · 0 comments
Closed

JSON API: Plugins endpoint breaks characters in plugin action links #7127

tyxla opened this issue May 5, 2017 · 0 comments
Assignees
Labels
[Feature] WPCOM API [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Bug When a feature is broken and / or not performing as intended

Comments

@tyxla
Copy link
Member

tyxla commented May 5, 2017

It appears that the /sites/%s/plugins/%s endpoint does not work well with Cyrillic characters. This will probably happen with many other characters.

Steps to reproduce the issue

  • Change the language of your site to Bulgarian.
  • Connect your site to WordPress.com.
  • Go to /plugins/jetpack/$site in WordPress.com.

What I expected

  • To see the proper link text here (Настройки and Поддръжка).

What happened instead

  • You will notice that the encoding of the "Settings" and "Support" is broken.

Reason

A quick investigation has shown that the plugins endpoint provides the broken texts:

This appears to be working just fine with the English action link texts.

It seems this has been introduced when the action links were introduced in #6267.

@tyxla tyxla added [Feature] WPCOM API [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended labels May 5, 2017
@tyxla tyxla self-assigned this May 5, 2017
@tyxla tyxla added the [Focus] i18n Internationalization / i18n, adaptation to different languages label May 5, 2017
@zinigor zinigor removed the [Status] Needs Review This PR is ready for review. label May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants