Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jp_carousel_load_for_images_linked_to_file filter doesn't work when Photon is activated #6054

Closed
samhotchkiss opened this issue Jan 8, 2017 · 0 comments · Fixed by #6296
Closed

jp_carousel_load_for_images_linked_to_file filter doesn't work when Photon is activated #6054

samhotchkiss opened this issue Jan 8, 2017 · 0 comments · Fixed by #6296
Assignees
@thingalon
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Comments

@samhotchkiss
Copy link
Contributor

Steps to reproduce the issue

  1. Set add_filter( 'jp_carousel_load_for_images_linked_to_file', '__return_true' );
  2. Activate Photon and Carousel
  3. Create a post with an image that is linked to its' full size file
  4. Click on the image on the frontend

What I expected

That the image would open in a lightbox (as it would if Carousel was active and Photon wasn't)

What happened instead

The image opens "normally"
@samhotchkiss samhotchkiss added the [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. label Jan 8, 2017
@samhotchkiss samhotchkiss added this to the 4.5 milestone Jan 8, 2017
@jeherve jeherve added [Pri] High [Type] Bug When a feature is broken and / or not performing as intended labels Jan 9, 2017
@samhotchkiss samhotchkiss modified the milestones: Not Currently Planned, 4.5 Jan 11, 2017
@stoyan0v stoyan0v mentioned this issue Feb 1, 2017
Closed
@jeherve jeherve modified the milestones: 4.7.0 - March 2017, Not Currently Planned Feb 1, 2017
@samhotchkiss samhotchkiss removed this from the 4.7.0 - March 2017 milestone Feb 3, 2017
@thingalon thingalon mentioned this issue Feb 6, 2017
Merged
@jeherve jeherve added this to the Not Currently Planned milestone Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thingalon thingalon

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
3 participants
@jeherve @samhotchkiss @thingalon