Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Fatal Error since 4.4 #5746

Closed
jeherve opened this issue Nov 23, 2016 · 3 comments
Closed

API: Fatal Error since 4.4 #5746

jeherve opened this issue Nov 23, 2016 · 3 comments
Labels
[Feature] WPCOM API [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@jeherve
Copy link
Member

jeherve commented Nov 23, 2016

cc @seear I believe this may have been introduced in #5392, since you changed the arguments passed to wp_remote_request().

In this forum thread, the site owner reported the following fatal error:

Fatal error: Uncaught TypeError: Argument 1 passed to Requests_Cookie_Jar::register() must be an instance of Requests_Hooker, instance of Requests_Hooks given, called in /home/ridestok/public_html/wp-includes/class-requests.php on line 592 and defined in /home/ridestok/public_html/wp-includes/Requests/Cookie/Jar.php:120 Stack trace: #0 /home/ridestok/public_html/wp-includes/class-requests.php(592): Requests_Cookie_Jar->register(Object(Requests_Hooks)) #1 /home/ridestok/public_html/wp-includes/class-requests.php(363): Requests::set_defaults(‘https://jetpack…’, Array, ‘<?xml version=”…’, ‘POST’, Array) #2 /home/ridestok/public_html/wp-includes/class-http.php(369): Requests::request(‘https://jetpack…’, Array, ‘<?xml version=”…’, ‘POST’, Array) #3 /home/ridestok/public_html/wp-includes/http.php(153): WP_Http->request(‘https://jetpack…’, Array) #4 /home/ridestok/public_html/wp-content/plugins/jetpack/class.jetpack-client.php(187): wp_remote_request(‘https://jetpack…’, Array) #5 /home/ridestok/public_html/wp-content in /home/ridestok/public_html/wp-includes/Requests/Cookie/Jar.php on line 120
@jeherve jeherve added [Feature] WPCOM API [Pri] High [Type] Bug When a feature is broken and / or not performing as intended labels Nov 23, 2016
@jeherve jeherve added this to the 4.4.2 milestone Nov 23, 2016
@seear
Copy link
Contributor

seear commented Nov 23, 2016

@jeherve I'm taking a look

@seear
Copy link
Contributor

seear commented Nov 23, 2016

It doesn't seem to be related to the change in #5392, which allowed two additional keys in the args array accepted by Jetpack_Client::remote_request().

The actual Fatal is interesting:

Fatal error: Uncaught TypeError: Argument 1 passed to Requests_Cookie_Jar::register() must be an instance of Requests_Hooker
, instance of Requests_Hooks given

Yet Request_Hooks is declared in core as implementing Request_Hooker. Possibly something external is interfering with that?

@zinigor
Copy link
Member

zinigor commented Dec 1, 2016

It looks like this is not an issue with Jetpack according to the linked forum thread. Please reopen if there are additional suspicions.

@zinigor zinigor closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants