Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gathering Tweestorms: hook not functioning in Gutenberg 8.8+ #17201

Closed
jeherve opened this issue Sep 18, 2020 · 1 comment · Fixed by #17218
Closed

Gathering Tweestorms: hook not functioning in Gutenberg 8.8+ #17201

jeherve opened this issue Sep 18, 2020 · 1 comment · Fixed by #17218
Assignees
@pento
Labels
[Block] Gathering Tweetstorms [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Sep 18, 2020

Gutenberg 8.8 made some changes to embed blocks and their variations:
WordPress/gutenberg#24090

As a result, the "Unroll" button does not appear on sites that use Gutenberg 8.8+:

jetpack/extensions/blocks/gathering-tweetstorms/editor.js

Lines 25 to 28 in 370de92

// Bail if this is not the Twitter embed block, or if the hook has been triggered by a deprecation.
if ( 'core-embed/twitter' !== blockSettings.name || blockSettings.isDeprecation ) {
return blockSettings;
}

image
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Gathering Tweetstorms labels Sep 18, 2020
@jeherve
Copy link
Member Author

jeherve commented Sep 18, 2020

@pento Do you think you could take a look? Since WordPress.com runs the Gutenberg plugin, the button does not appear on WordPress.com sites at the moment.

@jeherve jeherve mentioned this issue Sep 18, 2020
Merged
@pento pento mentioned this issue Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pento pento

Labels
[Block] Gathering Tweetstorms [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gathering Tweetstorms: Add support for Gutenberg 8.8+ Automattic/jetpack
2 participants
@pento @jeherve