Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stuttering in names #160

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

danieleades
Copy link
Contributor

remove some stuttering in entity key object names

@danieleades danieleades force-pushed the refactor/guid-stuttering branch from 0650f16 to 1bc00ee Compare December 19, 2021 11:14
@danieleades
Copy link
Contributor Author

lint job is failing due to an upstream false positive- rust-lang/rust-clippy#8140, for which a fix has already been merged.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #160 (1bc00ee) into master (c4640d3) will decrease coverage by 0.03%.
The diff coverage is 80.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   70.43%   70.39%   -0.04%     
==========================================
  Files          88       88              
  Lines        8013     8013              
==========================================
- Hits         5644     5641       -3     
- Misses       2369     2372       +3     
Impacted Files Coverage Δ
src/dds/qos.rs 66.27% <ø> (ø)
src/dds/traits/serde_adapters.rs 0.00% <ø> (ø)
src/dds/with_key/datawriter.rs 66.10% <ø> (ø)
src/discovery/discovery.rs 70.24% <28.57%> (ø)
src/dds/dp_event_loop.rs 78.32% <50.00%> (ø)
src/dds/writer.rs 54.11% <71.42%> (ø)
src/dds/reader.rs 62.71% <75.00%> (ø)
src/structure/guid.rs 81.08% <85.71%> (-1.53%) ⬇️
src/dds/message_receiver.rs 79.42% <100.00%> (-0.10%) ⬇️
src/dds/no_key/datareader.rs 54.09% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fd793...1bc00ee. Read the comment docs.

@jhelovuo
Copy link
Member

👍 +1:

@jhelovuo jhelovuo merged commit 65562ce into Atostek:master Dec 19, 2021
@danieleades danieleades deleted the refactor/guid-stuttering branch May 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants