Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return artist(s) & character(s) #100

Open
iced-queen opened this issue Mar 9, 2023 · 3 comments
Open

Return artist(s) & character(s) #100

iced-queen opened this issue Mar 9, 2023 · 3 comments
Assignees

Comments

@iced-queen
Copy link

I think it'd be nice if the data object also returned the artist(s) and character(s) like shown in the image below
img

Right now it returns an owner which I assume is the uploader, but personally I think it's more relevant to get the artist(s) and character(s). Would also be very useful, at least for my project but I'm sure other's could make use of that as well 😄

@AtoraSuunva
Copy link
Owner

Those are returned as part of the tags on a post.

I've thought of having them separate, but most boorus don't categorize the tags at all.

hypnohub, rule34.xxx, gelbooru, paheal, and derpibooru all just return a single string/array of tags

The only one that remember splitting tags is e621

I could probably fetch tags from the booru to categorize them, but that'd need another API call and I assume most people don't need that info, so I'd rather not make extra calls

It's something that I would have to look into to see if there's any good (cross-booru) way to do this

@iced-queen
Copy link
Author

Well I know rule34.xxx returns the artist(s) and having them returned separetly as they don't really fit in the tags would be really useful for those who uses rule34.xxx with this library 😄

@AtoraSuunva
Copy link
Owner

I'm planning to eventually rewriting booru and having some way to do specific "only some boorus support this" things, so it's definitely possible in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants