Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI repaints every frame when the map editor is open #107

Closed
white-axe opened this issue Feb 18, 2024 · 0 comments · Fixed by #110
Closed

UI repaints every frame when the map editor is open #107

white-axe opened this issue Feb 18, 2024 · 0 comments · Fixed by #110
Labels
bug Something isn't working performance

Comments

@white-axe
Copy link
Collaborator

What's the issue? Please describe.
At some point we started being affected by an egui bug that causes the egui::Context::request_repaint_after method to cause the screen to repaint every frame with no delay regardless of what duration is passed to the method. This method is called by the map editor to animate the autotiles in the map and tilepicker, causing unnecessarily high GPU usage when it's open. This will be fixed by emilk/egui#3978 which is in egui 0.26.0.

Describe the solution you'd like
Upgrade to egui 0.26 as soon as possible. This requires waiting for catppuccin-egui to upgrade their egui dependency or getting rid of catppuccin-egui.

Describe alternatives you've considered
None

Tests
It's possible to check if the UI is rendering every frame by opening the egui inspection window via the Debug tab in the top bar and checking how often the time updates, or alternatively by using a GPU usage monitor like NVTOP.

@white-axe white-axe added bug Something isn't working performance labels Feb 18, 2024
@melody-rs melody-rs mentioned this issue Feb 20, 2024
5 tasks
@white-axe white-axe mentioned this issue Feb 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant