first polling version to detect state

Author: Andrew

.gitignore

@@ -143,3 +143,4 @@ fabric.properties
 # Android studio 3.1+ serialized cache file
 .idea/caches/build_file_checksums.ser
 
+/index.js

nexus21/tvlift.js

@@ -27,6 +27,8 @@ module.exports = function(RED) {
 
         var node = this;
 
+        node.timer = null;
+
         if (!this.ip || (this.ip.length < 10)) {
             node.status({
                 fill:   "red",
@@ -37,9 +39,12 @@ module.exports = function(RED) {
         }
 
         var setStatus = function(json) {
+            const oldVertical = node.VERTICAL;
+            const oldHorizontal = node.HORIZONTAL;
             node.VERTICAL = json['VERTICAL'] || 'Unknown';
             node.HORIZONTAL = json['HORIZONTAL'] || 'Unknown';
-            node.working = node.VERTICAL != 'Unknown';
+            node.working = node.VERTICAL !== 'Unknown';
+            const changed = (oldVertical !== node.VERTICAL) || (oldHorizontal !== node.HORIZONTAL);
 
             if (!node.working) {
                 node.error(json);
@@ -50,38 +55,59 @@ module.exports = function(RED) {
                 });
                 return;
             }
-            node.status({
-                fill:   'green',
-                shape:  'dot',
-                text:   node.VERTICAL + ( node.HORIZONTAL != 'NA' ? '/' + node.HORIZONTAL : '')
-            });
+            if (changed) {
+                // todo: add decoded error payload if required
+                const msg = {
+                    payload: Object.assign({}, json)
+                };
+                node.send(msg); // pass on the status update to any listening nodes
+                node.status({
+                    fill: 'green',
+                    shape: 'dot',
+                    text: node.VERTICAL + (node.HORIZONTAL != 'NA' ? '/' + node.HORIZONTAL : '')
+                });
+            }
         };
 
         setStatus({});  // start in an unknown state
 
         //
         // check connectivity/update current status
         //
-        axios.get(`http://${node.ip}/api/status`)
-            .then(response => {
-                setStatus(response.data);
-                // don't go active here, wait to see if socket connects, it will maintain the correct active state
-            })
-            .catch(error => {
-                node.error(error.message || 'Unknown Error');
-                node.status({
-                    fill:   'red',
-                    shape:  'dot',
-                    text:   error.message || 'Unknown Error'
+
+        const pollStatus = function(callback) {
+            axios.get(`http://${node.ip}/api/status`)
+                .then(response => {
+                    setStatus(response.data);
+                    if (callback) {
+                        callback(null);
+                    }
+                })
+                .catch(error => {
+                    node.error(error.message || 'Unknown Error');
+                    node.status({
+                        fill:   'red',
+                        shape:  'dot',
+                        text:   error.message || 'Unknown Error'
+                    });
                 });
-            });
+        };
+
+        pollStatus(function(err) {
+            if (err) { return; }
+            // todo: use a socket connection intead of polling
+            // todo: don't go active here, wait to see if socket connects, it will maintain the correct active state
+            node.timer = setInterval(function(){
+                pollStatus();
+            }, 5000);
+        });
 
         //const nodeId = node.id.replace(/\./g, '_');
         // currentNodes && currentNodes.add(nodeId);
 
         // send Commands to the TV LIFT
 
-        node.on('input', function(msg) {
+        node.on('input', function(msg, send, done) {
             node.log('tv lift input: ' + JSON.stringify(msg.payload, null, 2));
 
             if (!msg.payload || (['UP', 'DOWN', 'MEM1', 'MEM2', 'MEM3'].indexOf(msg.payload) < 0)) {
@@ -91,23 +117,43 @@ module.exports = function(RED) {
                     shape:  'dot',
                     text:   'invalid payload'
                 });
+                if (done) {
+                    done();
+                }
                 return;
             }
 
+            // fallback to using `node.send`
+            // send = send || function() { node.send.apply(node,arguments) }
+
             axios.post(`http://${node.ip}/api/command`, { "COMMAND": msg.payload })
                 .then(response => {
                     node.log(msg.payload + ': ' + ((response.data && response.data.STATUS) || "?"));
+                    if (done) {
+                        done();
+                    }
                 })
                 .catch(error => {
-                    node.error(error.message || 'Unknown Error');
                     node.status({
                         fill:   'red',
                         shape:  'dot',
                         text:   error.message || 'Unknown Error'
                     });
+                    if (done) {
+                        done(error);
+                    } else {
+                        node.error(error.message || 'Unknown Error');
+                    }
                 });
         });
 
+        node.on('close', function() {
+            if (node.timer) {
+                clearInterval(node.timer);
+                node.timer = null;
+            }
+        });
+
     }
 
     RED.nodes.registerType("TV Lift", TVLift);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-nexus21",
-  "version": "0.0.1",
+  "version": "0.1.0",
   "description": "Nodes to help automate Nexus21 TV Lifts.",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"