Test for internal checks

Fix pylint/pycodestyle

Author: mohierf

.pylintrc

@@ -132,7 +132,10 @@ disable=print-statement,
         no-member,
         fixme,
         invalid-name,
-        access-member-before-definition
+        access-member-before-definition,
+        useless-object-inheritance,
+        consider-using-dict-comprehension,
+        consider-using-set-comprehension
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

alignak/action.py

@@ -551,13 +551,6 @@ def _execute(self, force_shell=sys.version_info < (2, 7)):
             # 2.7 and higher Python version need a list of arguments for the started command
             cmd = self.command
             if not force_shell:
-                # todo: perharps necessary, to be investigated!
-                # try:
-                #     self.command = self.command.encode('utf8')
-                # except Exception as exp:
-                #     print(exp)
-                #     pass
-
                 try:
                     cmd = shlex.split(self.command)
                 except Exception as exp:  # pylint: disable=broad-except

alignak/brok.py

@@ -52,7 +52,7 @@
 from datetime import datetime
 
 from alignak.alignakobject import get_a_new_object_id
-from alignak.misc.serialization import serialize, unserialize, AlignakClassLookupException
+from alignak.misc.serialization import serialize, unserialize
 
 
 class Brok(object):
@@ -149,10 +149,7 @@ def prepare(self):
         # Maybe the Brok is a old daemon one or was already prepared
         # if so, the data is already ok
         if hasattr(self, 'prepared') and not self.prepared:
-            try:
-                self.data = unserialize(self.data)
-            except AlignakClassLookupException:  # pragma: no cover, should never happen...
-                raise
+            self.data = unserialize(self.data)
             if self.instance_id:
                 self.data['instance_id'] = self.instance_id
         self.prepared = True

alignak/complexexpression.py

@@ -186,7 +186,7 @@ def eval_cor_pattern(self, pattern):  # pylint:disable=R0912
         tmp = ''
         stacked_par = 0
         for char in pattern:
-            if char == ',' or char == '|':
+            if char in (',', '|'):
                 # Maybe we are in a par, if so, just stack it
                 if in_par:
                     tmp += char
@@ -199,7 +199,7 @@ def eval_cor_pattern(self, pattern):  # pylint:disable=R0912
                         node.sons.append(son)
                     tmp = ''
 
-            elif char == '&' or char == '+':
+            elif char in ('&', '+'):
                 # Maybe we are in a par, if so, just stack it
                 if in_par:
                     tmp += char
@@ -298,7 +298,6 @@ def find_object(self, pattern):
                 elts.remove('*')
             return elts, error
 
-        else:  # templates
-            obj = self.grps.find_hosts_that_use_template(pattern)
+        obj = self.grps.find_hosts_that_use_template(pattern)
 
         return obj, error

alignak/daemon.py

@@ -985,7 +985,6 @@ def do_before_loop(self):  # pylint: disable=no-self-use
         :return: None
         """
         logger.debug("Nothing to do before the main loop")
-        return
 
     def do_main_loop(self):
         # pylint: disable=too-many-branches, too-many-statements, too-many-locals

alignak/daemons/arbiterdaemon.py

@@ -1881,7 +1881,7 @@ def get_livesynthesis(self):
         return res
 
     def get_alignak_status(self, details=False):
-        # pylint: disable=too-many-locals
+        # pylint: disable=too-many-locals, too-many-branches
         """Push the alignak overall state as a passive check
 
         Build all the daemons overall state as a passive check that can be notified

alignak/daemons/brokerdaemon.py

@@ -423,11 +423,11 @@ def do_loop_turn(self):
                         logger.info("No initial broks were raised, "
                                     "my scheduler is not yet ready...")
                         return
-                    else:
-                        self.got_initial_broks = True
-                        logger.debug("Got %d initial broks from '%s'",
-                                     my_initial_broks, satellite.name)
-                        statsmgr.gauge('broks.initial.%s.count' % satellite.name, my_initial_broks)
+
+                    self.got_initial_broks = True
+                    logger.debug("Got %d initial broks from '%s'",
+                                 my_initial_broks, satellite.name)
+                    statsmgr.gauge('broks.initial.%s.count' % satellite.name, my_initial_broks)
                 except LinkError as exp:
                     logger.warning("Scheduler connection failed, I could not get initial broks!")
 

alignak/external_command.py

@@ -3032,7 +3032,7 @@ def process_host_check_result(self, host, status_code, plugin_output):
                          plugin_output)
             return
 
-        chk = host.launch_check(int(now), self.hosts, self.services, self.timeperiods,
+        chk = host.launch_check(now, self.hosts, self.services, self.timeperiods,
                                 self.daemon.macromodulations, self.daemon.checkmodulations,
                                 self.daemon.checks, force=True)
         # We will not have a check if an host/service is checked but it has no defined check_command
@@ -3519,7 +3519,7 @@ def schedule_host_downtime(self, host, start_time, end_time, fixed,
         host.add_downtime(downtime)
 
         self.daemon.get_and_register_status_brok(host)
-        if trigger_id != '' and trigger_id != 0:
+        if trigger_id not in ('', 0):
             for item in self.daemon.hosts:
                 if trigger_id in item.downtimes:
                     host.downtimes[trigger_id].trigger_me(downtime.uuid)
@@ -3682,7 +3682,7 @@ def schedule_svc_downtime(self, service, start_time, end_time, fixed,
         downtime.add_automatic_comment(service)
         service.add_downtime(downtime)
         self.daemon.get_and_register_status_brok(service)
-        if trigger_id != '' and trigger_id != 0:
+        if trigger_id not in ('', 0):
             for item in self.daemon.services:
                 if trigger_id in item.downtimes:
                     service.downtimes[trigger_id].trigger_me(downtime.uuid)

alignak/http/arbiter_interface.py

@@ -26,7 +26,6 @@
 from alignak.http.generic_interface import GenericInterface
 from alignak.util import split_semicolon
 from alignak.external_command import ExternalCommand
-from alignak.misc.serialization import serialize, unserialize
 
 logger = logging.getLogger(__name__)  # pylint: disable=invalid-name
 
@@ -431,7 +430,6 @@ def monitoring_problems(self):
         res = self.get_id()
         res['problems'] = {}
         for scheduler_link in self.app.conf.schedulers:
-            print("Scheduler link: %s" % scheduler_link)
             sched_res = scheduler_link.con.get('monitoring_problems', wait=True)
             res['problems'][scheduler_link.name] = {}
             if '_freshness' in sched_res:

alignak/misc/common.py

@@ -49,13 +49,14 @@
 try:
     from setproctitle import setproctitle  # pylint: disable=unused-import
 except ImportError as err:  # pragma: no cover, setproctitle is in the requirements.txt
-    def setproctitle(title):  # pylint: disable=unused-argument
+    def setproctitle(title):  # pylint: disable=unused-argument, useless-return
         """
         Return name
         :param title: name of process
         :type title: str
         :return: None
         """
+        # Do nothing...
         return None
 
 # Friendly names for the system signals

alignak/misc/serialization.py

@@ -112,7 +112,7 @@ def unserialize(j_obj, no_load=False):
             data_dict[key] = unserialize(value, True)
         return data_dict
 
-    elif isinstance(data, list):
+    if isinstance(data, list):
         return [unserialize(item, True) for item in data]
 
     return data

alignak/objects/host.py

@@ -560,11 +560,11 @@ def is_state(self, status):
         if status == self.state:
             return True
         # Now low status
-        elif status == 'o' and self.state == u'UP':
+        if status == 'o' and self.state == u'UP':
             return True
-        elif status == 'd' and self.state == u'DOWN':
+        if status == 'd' and self.state == u'DOWN':
             return True
-        elif status in ['u', 'x'] and self.state == u'UNREACHABLE':
+        if status in ['u', 'x'] and self.state == u'UNREACHABLE':
             return True
         return False
 

alignak/objects/item.py

@@ -864,7 +864,7 @@ def manage_conflict(self, item, name):
         if existing_prio < item_prio:
             # Existing item has lower priority, so it has precedence.
             return existing
-        elif existing_prio > item_prio:
+        if existing_prio > item_prio:
             # New item has lower priority, so it has precedence.
             # Existing item will be deleted below
             pass

alignak/objects/realm.py

@@ -300,7 +300,6 @@ def set_level(self, level, realms):
 
         :return: None
         """
-        # print("- set: %s (%s)" % (self.get_name(), self.uuid))
         self.level = level
         self.all_sub_members = []
         self.all_sub_members_names = []
@@ -318,8 +317,6 @@ def set_level(self, level, realms):
                     grand_child = realms.find_by_name(grand_child)
                     if grand_child:
                         self.all_sub_members.append(grand_child.uuid)
-        # print("-> : %s" % self.all_sub_members)
-        # print("-> : %s" % self.all_sub_members_names)
         return self.all_sub_members_names
 
     def get_all_subs_satellites_by_type(self, sat_type, realms):

alignak/objects/schedulingitem.py

@@ -66,7 +66,7 @@
 import re
 import random
 import time
-import datetime
+from datetime import datetime
 import traceback
 import logging
 
@@ -1167,7 +1167,7 @@ def schedule(self, hosts, services, timeperiods, macromodulations, checkmodulati
         :type force_time: None | int
         :return: None
         """
-        # next_chk il already set, do not change
+        # next_chk is already set, do not change
         # unless we force the check or the time
         if self.in_checking and not (force or force_time):
             return None
@@ -1185,8 +1185,8 @@ def schedule(self, hosts, services, timeperiods, macromodulations, checkmodulati
         if self.check_interval == 0 and not force:
             if cls.my_type == 'service':
                 return None
-            else:  # host
-                self.check_interval = 300 / cls.interval_length
+
+            self.check_interval = 300 / cls.interval_length
 
         # Interval change is in a HARD state or not
         # If the retry is 0, take the normal value
@@ -1252,8 +1252,13 @@ def schedule(self, hosts, services, timeperiods, macromodulations, checkmodulati
 
         logger.debug("-> schedule: %s / %s (interval: %d, added: %d)",
                      self.get_full_name(),
-                     datetime.datetime.fromtimestamp(self.next_chk).strftime('%Y-%m-%d %H:%M:%S'),
+                     datetime.utcfromtimestamp(self.next_chk).strftime('%Y-%m-%d %H:%M:%S'),
                      interval, time_add)
+        if os.getenv('ALIGNAK_LOG_CHECKS', None):
+            logger.info("--ALC-- -> next check for %s at %s (interval: %d, added: %d)",
+                        self.get_full_name(),
+                        datetime.utcfromtimestamp(self.next_chk).strftime('%Y-%m-%d %H:%M:%S'),
+                        interval, time_add)
         # Get the command to launch, and put it in queue
         return self.launch_check(self.next_chk, hosts, services, timeperiods, macromodulations,
                                  checkmodulations, checks, force=force)
@@ -1586,27 +1591,10 @@ def consume_result(self, chk, notification_period, hosts,
                 logger.info("Got check result: %d for %s",
                             chk.exit_status, self.get_full_name())
 
-        # # Protect against bad type output
-        # try:
-        #     # if str, convert to unicode
-        #     if isinstance(chk.output, str):
-        #         chk.output = chk.output.decode('utf8', 'ignore')
-        #         chk.long_output = chk.long_output.decode('utf8', 'ignore')
-        # except AttributeError:
-        #     # Python 3 raises an exception!
-        #     pass
-        #
-        # try:
-        #     if isinstance(chk.perf_data, str):
-        #         chk.perf_data = chk.perf_data.decode('utf8', 'ignore')
-        # except AttributeError:
-        #     # Python 3 raises an exception!
-        #     pass
-
         if os.getenv('ALIGNAK_LOG_CHECKS', None):
             level = ['info', 'warning', 'error', 'critical'][min(chk.exit_status, 3)]
             func = getattr(logger, level)
-            func("Check result for '%s', exit: %d, output: %s",
+            func("--ALC-- check result for %s, exit: %d, output: %s",
                  self.get_full_name(), chk.exit_status, chk.output)
 
         # ============ MANAGE THE CHECK ============ #
@@ -1928,7 +1916,7 @@ def update_event_and_problem_id(self):
                 SchedulingItem.current_problem_id += 1
                 self.last_problem_id = self.current_problem_id
                 self.current_problem_id = SchedulingItem.current_problem_id
-            elif self.state != ok_up and self.last_state != ok_up:
+            elif ok_up not in (self.state, self.last_state):
                 # State transitions between non-OK states
                 # (e.g. WARNING to CRITICAL) do not cause
                 # this problem id to increase.
@@ -2718,6 +2706,9 @@ def manage_internal_check(self, hosts, services, check, hostgroups, servicegroup
         :return: None
         """
         logger.debug("Internal check: %s - %s", self.get_full_name(), check.command)
+        if os.getenv('ALIGNAK_LOG_CHECKS', None):
+            logger.info("--ALC-- Internal check: %s - %s", self.get_full_name(), check.command)
+        # Business rule
         if check.command.startswith('bp_'):
             try:
                 # Re evaluate the business rule to take into account macro
@@ -2744,6 +2735,7 @@ def manage_internal_check(self, hosts, services, check, hostgroups, servicegroup
                 logger.debug("[%s] Error while re-evaluating business rule:\n%s",
                              self.get_name(), traceback.format_exc())
                 state = 3
+
         # _internal_host_up is for putting host as UP
         elif check.command == '_internal_host_up':
             state = 0
@@ -2777,14 +2769,21 @@ def manage_internal_check(self, hosts, services, check, hostgroups, servicegroup
                 state = 3
                 check.output = u'Malformed host internal check'
             else:
-                state = 3
+                state = check_result[1].strip()
+                # If multiple possible states - choose a random one
+                if ',' in check_result[1]:
+                    states = check_result[1].split(',')
+                    state = states[random.randint(0, len(states) - 1)]
+
                 try:
-                    state = int(check_result[1])
+                    state = int(state)
                 except ValueError:
                     pass
                 check.output = u'Host internal check result: %d' % state
-                if len(check_result) > 2:
+                if len(check_result) > 2 and check_result[2]:
                     check.output = check_result[2]
+                    if '%d' in check.output:
+                        check.output = check.output % state
 
             check.execution_time = 0
             if 'ALIGNAK_LOG_ACTIONS' in os.environ:
@@ -2804,14 +2803,25 @@ def manage_internal_check(self, hosts, services, check, hostgroups, servicegroup
                 state = 3
                 check.output = u'Malformed service internal check'
             else:
-                state = 3
+                state = check_result[1].strip()
+                # If multiple possible states - choose a random one
+                if ',' in check_result[1]:
+                    states = check_result[1].split(',')
+                    state = states[random.randint(0, len(states) - 1)]
+
+                    # In SOFT state type, do not change current state - let the new state go to HARD
+                    if self.state_type == 'SOFT':
+                        state = self.state_id
+
                 try:
-                    state = int(check_result[1])
+                    state = int(state)
                 except ValueError:
                     pass
                 check.output = u'Service internal check result: %d' % state
-                if len(check_result) > 1:
-                    check.output = check_result[1]
+                if len(check_result) > 2 and check_result[2]:
+                    check.output = check_result[2]
+                    if '%d' in check.output:
+                        check.output = check.output % state
 
             check.execution_time = 0
             if 'ALIGNAK_LOG_ACTIONS' in os.environ:
@@ -3105,14 +3115,14 @@ def unset_impact_state(self):
             self.state = self.state_before_impact
             self.state_id = self.state_id_before_impact
 
-    def last_time_non_ok_or_up(self):  # pragma: no cover, base function
-        """Get the last time the item was in a non-OK state
-
-        :return: return 0
-        :rtype: int
-        """
-        pass
-
+    # def last_time_non_ok_or_up(self):  # pragma: no cover, base function
+    #     """Get the last time the item was in a non-OK state
+    #
+    #     :return: return 0
+    #     :rtype: int
+    #     """
+    #     pass
+    #
     def set_unreachable(self):
         """Set unreachable: all our parents (dependencies) are not ok
         Unreachable is different from down/critical