Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#110] Added init script to make onboarding easier #132

Merged
merged 36 commits into from
May 1, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Apr 30, 2024

Checklist before requesting a review

closes #110

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 changed the title Init. Added init script to make onboarding easier May 1, 2024
@tannguyen04
Copy link
Contributor Author

Hi @AlexSkrypnyk
Could you please review when you have time ?
I have done extra thing (prepare for #126 & #128 )

Thank you.

@tannguyen04 tannguyen04 marked this pull request as ready for review May 1, 2024 03:35
@tannguyen04 tannguyen04 changed the title Added init script to make onboarding easier [#110] Added init script to make onboarding easier May 1, 2024
Copy link
Owner

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
I've updated the ticket description to include exact questions that needed to be asked. Please update the script accordingly and remove unnecessary code.

Copy link

github-actions bot commented May 1, 2024

@github-actions github-actions bot temporarily deployed to pull request May 1, 2024 15:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 1, 2024 15:47 Inactive
@AlexSkrypnyk AlexSkrypnyk merged commit 679ed14 into 1.x May 1, 2024
19 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/add-init-script branch May 1, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add init script to make onboarding easier
2 participants