Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Design token needed for themeing #180

Closed
Tracked by #189
braven112 opened this issue Jan 4, 2024 · 4 comments · Fixed by #257
Closed
Tracked by #189

Design token needed for themeing #180

braven112 opened this issue Jan 4, 2024 · 4 comments · Fixed by #257
Assignees

Comments

@braven112
Copy link
Member

Please verify the version of auro-datepicker you have installed

@latest

Please describe the bug

background-color: #f0f0f0; // var(--ds-color-ui-bkg-hover-default); - this token was part of the design but caused a problem with the `inRange` date styles so we had to switch to a solid color for hover.

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

This will need to be a design token so that we can theme it. Given the comment it sounds like a perfect opportunity to explore a tier 3 token

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

This has been updated to a token value.

@braven112 braven112 added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jan 4, 2024
@blackfalcon blackfalcon added Type: Perf Performance update to existing code and removed Type: Bug Bug or Bug fixes labels Jan 5, 2024
@blackfalcon
Copy link
Member

I updated this from a bug to a performance update as the code deployed works as expected.

@blackfalcon
Copy link
Member

@jason-capsule42 and @jordanjones243 can you please document what the 'problem' was that you refer to in this comment?

this token was part of the design but caused a problem with the inRange date styles so we had to switch to a solid color for hover.

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label May 8, 2024
@blackfalcon
Copy link
Member

From what I can see, we currently do NOT have a baseline color token for #f0f0f0.

@leeejune can we update this color used here to use a baseline color that is currently supported?

I would stress that we not quickly jump to the tier 3 level of tokens as a solution as this comes with additional complexities for theming. I do think that we could have a tier 2 token for this background use, but that should never introduce a new value, but rather alias a base token.

Recommendation: update this color to use a currently existing baseline token. Create a new semantic token, if needed, and update this element’s Sass.

@blackfalcon blackfalcon removed their assignment May 8, 2024
@blackfalcon
Copy link
Member

If new token work is required, we will need to create a new issue for that update.

@Patrick-Daly-AA Patrick-Daly-AA added the not-reviewed Issue has not been reviewed by Auro team members label May 14, 2024
@jordanjones243 jordanjones243 linked a pull request Oct 3, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Oct 3, 2024
6 tasks
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Oct 4, 2024
@jordanjones243 jordanjones243 self-assigned this Oct 4, 2024
@jason-capsule42 jason-capsule42 removed the Type: Perf Performance update to existing code label Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants