tests/common.sh: exit 1 on errors

Close rootless-containers#235

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Author: AkihiroSuda

tests/common.sh

@@ -28,25 +28,27 @@ function wait_for_network_namespace {
     COUNTER=0
     while [ $COUNTER -lt 40 ]; do
         if nsenter $(nsenter_flags $1) true; then
-            break
+            return 0
         else
             sleep 0.5
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function wait_for_network_device {
     # Wait that the device appears.
     COUNTER=0
     while [ $COUNTER -lt 40 ]; do
         if nsenter $(nsenter_flags $1) ip addr show $2; then
-            break
+            return 0
         else
             sleep 0.5
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function wait_process_exits {
@@ -55,47 +57,51 @@ function wait_process_exits {
         if  kill -0 $1; then
             sleep 0.5
         else
-            break
+            return 0
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function wait_for_ping_connectivity {
     COUNTER=0
     while [ $COUNTER -lt 40 ]; do
         if nsenter $(nsenter_flags $1) ping -c 1 -w 1 $2; then
-            break
+            return 0
         else
             sleep 0.5
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function wait_for_connectivity {
     COUNTER=0
     while [ $COUNTER -lt 40 ]; do
         if echo "wait_for_connectivity" | nsenter $(nsenter_flags $1) ncat -v $2 $3; then
-            break
+            return 0
         else
             sleep 0.5
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function wait_for_file_content {
     # Wait for a file to get the specified content.
     COUNTER=0
     while [ $COUNTER -lt 20 ]; do
         if grep $1 $2; then
-            break
+            return 0
         else
             sleep 0.5
         fi
         let COUNTER=COUNTER+1
     done
+    exit 1
 }
 
 function expose_tcp() {