added explanatory clause to NOLINTNEXTLINE comments

Author: Aiden2244

bindings/pydrake/common/ref_cycle_pybind.h

@@ -75,15 +75,15 @@ class process_attribute<drake::pydrake::internal::ref_cycle<Peer0, Peer1>>
     : public process_attribute_default<
           drake::pydrake::internal::ref_cycle<Peer0, Peer1>> {
  public:
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   static void precall(function_call& call) {
     // Only generate code if this invocation doesn't need the return value.
     if constexpr (!needs_return_value()) {
       drake::pydrake::internal::ref_cycle_impl(Peer0, Peer1, call, handle());
     }
   }
 
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   static void postcall(function_call& call, handle ret) {
     // Only generate code if this invocation *does* need the return value.
     if constexpr (needs_return_value()) {

bindings/pydrake/systems/builder_life_support_pybind.h

@@ -138,7 +138,7 @@ class process_attribute<
     : public process_attribute_default<
           drake::pydrake::internal::builder_life_support_stash<T, Builder>> {
  public:
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   static void postcall(function_call& call, handle ret) {
     drake::pydrake::internal::builder_life_support_stash_impl<T>(
         Builder, call, ret);

common/identifier.h

@@ -194,7 +194,7 @@ class Identifier {
    confirm it is valid before using it as a key (or other hashing application).
    */
   template <typename HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher, const Identifier& i) noexcept {
     using drake::hash_append;
     hash_append(hasher, i.value_);

common/symbolic/chebyshev_polynomial.h

@@ -100,7 +100,7 @@ class ChebyshevPolynomial {
 
   /** Implements the @ref hash_append concept. */
   template <class HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher,
                           const ChebyshevPolynomial& item) noexcept {
     if (item.degree() == 0) {

common/type_safe_index.h

@@ -489,7 +489,7 @@ class TypeSafeIndex {
   /// the user to confirm it is valid before using it as a key (or other hashing
   /// application).
   template <typename HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher,
                           const TypeSafeIndex& i) noexcept {
     using drake::hash_append;

common/value.h

@@ -624,7 +624,7 @@ struct ValueTraitsImpl<T, true> {
     return *other;
   }
   static const T& access(const Storage& storage) { return storage; }
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   static T& access(Storage& storage) { return storage; }
 };
 
@@ -655,7 +655,7 @@ struct ValueTraitsImpl<T, false> {
     return Storage{std::move(other)};
   }
   static const T& access(const Storage& storage) { return *storage; }
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   static T& access(Storage& storage) { return *storage; }
 };
 

geometry/benchmarking/render_benchmark.cc

@@ -77,7 +77,7 @@ class RenderBenchmark : public benchmark::Fixture {
   void SetUp(::benchmark::State&) { depth_cameras_.clear(); }
 
   template <EngineType engine_type>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void ColorImage(::benchmark::State& state, const std::string& name) {
     auto renderer = MakeEngine<engine_type>(bg_rgb_);
     auto [sphere_count, camera_count, width, height] = ReadState(state);
@@ -110,7 +110,7 @@ class RenderBenchmark : public benchmark::Fixture {
   }
 
   template <EngineType engine_type>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DepthImage(::benchmark::State& state, const std::string& name) {
     auto renderer = MakeEngine<engine_type>(bg_rgb_);
     auto [sphere_count, camera_count, width, height] = ReadState(state);
@@ -139,7 +139,7 @@ class RenderBenchmark : public benchmark::Fixture {
   }
 
   template <EngineType engine_type>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void LabelImage(::benchmark::State& state, const std::string& name) {
     auto renderer = MakeEngine<engine_type>(bg_rgb_);
     auto [sphere_count, camera_count, width, height] = ReadState(state);

geometry/render_gl/internal_buffer_dim.h

@@ -25,7 +25,7 @@ class BufferDim {
 
   /* Implements the @ref hash_append concept.  */
   template <class HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher,
                           const BufferDim& dim) noexcept {
     using drake::hash_append;

multibody/benchmarking/cassie.cc

@@ -78,7 +78,7 @@ class Cassie : public benchmark::Fixture {
   // For T=double, any request for gradients is an error.
   // For T=AutoDiffXd, sets the specified gradients to the identity matrix.
   // For T=Expression, sets the specified quantities to symbolic variables.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void SetUpGradientsOrVariables(benchmark::State& state);
 
   // Use these functions to invalidate input- or state-dependent computations
@@ -97,7 +97,7 @@ class Cassie : public benchmark::Fixture {
   }
 
   // Runs the PositionKinematics benchmark.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DoPositionKinematics(benchmark::State& state) {
     DRAKE_DEMAND(want_grad_vdot(state) == false);
     DRAKE_DEMAND(want_grad_u(state) == false);
@@ -111,7 +111,7 @@ class Cassie : public benchmark::Fixture {
   }
 
   // Runs the PosAndVelKinematics benchmark.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DoPosAndVelKinematics(benchmark::State& state) {
     DRAKE_DEMAND(want_grad_vdot(state) == false);
     DRAKE_DEMAND(want_grad_u(state) == false);
@@ -126,7 +126,7 @@ class Cassie : public benchmark::Fixture {
   }
 
   // Runs the MassMatrix benchmark.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DoMassMatrix(benchmark::State& state) {
     DRAKE_DEMAND(want_grad_vdot(state) == false);
     DRAKE_DEMAND(want_grad_u(state) == false);
@@ -137,7 +137,7 @@ class Cassie : public benchmark::Fixture {
   }
 
   // Runs the InverseDynamics benchmark.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DoInverseDynamics(benchmark::State& state) {
     DRAKE_DEMAND(want_grad_u(state) == false);
     for (auto _ : state) {
@@ -147,7 +147,7 @@ class Cassie : public benchmark::Fixture {
   }
 
   // Runs the ForwardDynamics benchmark.
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   void DoForwardDynamics(benchmark::State& state) {
     DRAKE_DEMAND(want_grad_vdot(state) == false);
     for (auto _ : state) {

solvers/binding.h

@@ -119,7 +119,7 @@ class Binding {
 
   /** Implements the @ref hash_append concept. */
   template <class HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher,
                           const Binding<C>& item) noexcept {
     using drake::hash_append;

solvers/solver_id.h

@@ -35,7 +35,7 @@ class SolverId {
 
   /** Implements the @ref hash_append concept. */
   template <class HashAlgorithm>
-  // NOLINTNEXTLINE(runtime/references)
+// NOLINTNEXTLINE(runtime/references) Per hash_append convention.
   friend void hash_append(HashAlgorithm& hasher,
                           const SolverId& item) noexcept {
     using drake::hash_append;