Convert $queryprune modifier to $removeparam

[AdamWr]

It seems that uBlock Origin has added support for queryprune modifier - gorhill/uBlock@1e2eb03, so I think that it would be a good idea to convert it to removeparam.

[ameshkov]

I'll be keeping an eye on that feature. It looks a little bit more limited than $removeparam so I guess when the work is done, converting it won't be that complicated.

See the task here: uBlockOrigin/uBlock-issues#1356 (comment)

[gorhill]

It looks a little bit more limited than $removeparam

What do you have in mind when you say this?

[ameshkov]

Check the spec: https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#removeparam-modifier

Essentially the same, but less limitations are imposed on the rule syntax (supports any URL, regexes)

[gorhill]

I did check before writing my comment above and I still do not understand the statement.

supports any URL

I don't understand this part, there is no restriction regarding URL for queryprune=.

regexes

The values for queryprune= are implicitly regex, hence why surrounding / are not needed. The only difference with regexes is to use | for anchoring to start and end because I do not want to have to deal with the ambiguity of $ given that is already being used as a filter option separator.

Note that queryprune= supports filtering parameters by either parameter name, paramater value, or both since the regex is tested against the string param=value.

[ameshkov]

I guess this pipe char is what confused me. Anyways, the closer they are, the better, we'll either fully support it or convert to $removeparam internally, depends on how interchangeable they are.

[gorhill]

I cannot see removeparam being used in many AdGuard filter lists I've looked at -- beside unmatched broad exceptions in AdGuard Base. Is this a new filter option?

[ameshkov]

Yep, it's been added just recently and used internally in the Stealth Mode module (it has "remove tracking parameters" setting).

[krystian3w]

Maybe need test on Polish Onet portals:

https://github.com/AdguardTeam/AdguardFilters/blob/2fb36af53d78ac966b1de303bfac4c1d7f9e8f10/EnglishFilter/sections/whitelist_stealth.txt#L476-L479

https://github.com/AdguardTeam/AdguardFilters/blob/2fb36af53d78ac966b1de303bfac4c1d7f9e8f10/EnglishFilter/sections/whitelist_stealth.txt#L205-L217

Stealth parametrs in AdGuard generated endless refreshing loop.

[DandelionSprout]

I've submitted a vice-versa report to uBO at uBlockOrigin/uBlock-issues#1356, since there's now active usage cases of $removeparam in Dandelion Sprout's Nordic Filters, and of $queryprune in Frellwit's Swedish Filter, as well as me having made an entire hobby-basis list dedicated to $removeparam.

[ameshkov]

@Mizzick we may need to implement some changes (see this: AdguardTeam/CoreLibs#1384).