Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using simulate_execution #2687

Merged
merged 3 commits into from
Jan 17, 2024
Merged

avoid using simulate_execution #2687

merged 3 commits into from
Jan 17, 2024

Conversation

xlc
Copy link
Member

@xlc xlc commented Jan 15, 2024

simulate_execution discard state which stops chopsticks from getting storage diff

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b389e5) 67.69% compared to head (af4625f) 67.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   67.69%   67.51%   -0.18%     
==========================================
  Files          69       67       -2     
  Lines        9425     8558     -867     
==========================================
- Hits         6380     5778     -602     
+ Misses       3045     2780     -265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xlc xlc requested review from zjb0807 and wangjj9219 January 15, 2024 23:04
wangjj9219
wangjj9219 previously approved these changes Jan 16, 2024
Copy link
Member

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove orml-utilities in Cargo.toml and update karura/mandala runtime.

@zjb0807
Copy link
Member

zjb0807 commented Jan 16, 2024

reproduce case:

curl --location 'http://localhost:8545' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc": "2.0",
    "method": "eth_estimateGas",
    "params": [
        {
            "data": "0xe9b07bbf000000000000000000000000e5ba1e8e6bbbdc8bbc72a58d68e74b13fcd6e4c700000000000000000000000000000000000000000000000000000000000003e8000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000002803010200a9200100d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000",
            "from": "0x75E480dB528101a381Ce68544611C169Ad7EB342",
            "to": "0x0000000000000000000000000000000000000809"
        }
    ],
    "id": 1
}'

@xlc xlc merged commit 819b280 into master Jan 17, 2024
6 checks passed
@xlc xlc deleted the update-runtime-api branch January 17, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants