Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Image previews link to temporary image directory/filename even when autosave is enabled #10762

Closed
1 task done
quicks1lver42 opened this issue May 27, 2023 · 9 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@quicks1lver42
Copy link

quicks1lver42 commented May 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

As per title, after rendering an image, the preview on the right links to its temp folder location rather than the one in the output folder. I am aware that this used to be the case when "Always save all generated images" was unchecked in the settings, but now it seems to happen regardless.

It's not a huge deal, but it does break the filenames in the lazy workflow I was using of copypasting or dragging/dropping outputs directly from the UI.

Steps to reproduce the problem

  1. Go to any generation tab
  2. Generate an image
  3. Right-click the generated image and 'open image in new tab'.
  4. Check the filepath/filename in the address bar

What should have happened?

When "Always save all generated images" is enabled in the settings, the filepath/filename used by previews of generated images should be that of the outputs/[type]/[date]/[number]-[seed].[extension] rather than the temp path.

Commit where the problem happens

20ae71f

What Python version are you running on ?

Python 3.10.x

What platforms do you use to access the UI ?

Windows

What device are you running WebUI on?

Nvidia GPUs (RTX 20 above)

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--opt-sub-quad-attention --opt-channelslast --xformers

List of extensions

https://github.com/KohakuBlueleaf/a1111-sd-webui-locon
https://github.com/yfszzx/stable-diffusion-webui-images-browser
https://github.com/ilian6806/stable-diffusion-webui-state

Console logs

N/A

Additional information

No response

@quicks1lver42 quicks1lver42 added the bug-report Report of a bug, yet to be confirmed label May 27, 2023
@c0nfess0r
Copy link

I also experience the same bug. Hope it gets fixed soon.

@sean-kang
Copy link

I see the same problem in Linux.

@Username69992872
Copy link

is this being fixed? if previews are not being saved to the path defined in config, but windows temp folder instead, this also is a huge security risk. Sometimes nsfw images fail to produce correct images, and this you dont want to have in windows temp folder...

@Kadah
Copy link

Kadah commented May 31, 2023

This has been quite annoying. I've resorted to using Nomacs on the output directory for viewing results instead.

@gshawn3
Copy link
Contributor

gshawn3 commented May 31, 2023

Running into the same issue here as well. This breaks a couple of my extensions so I will need to downgrade to a previous version.

@Flixerine
Copy link

Makes using it remotely with --listen on a 2nd pc very scuffed as you cannot rightclick download the images with the proper name.

@VV828
Copy link

VV828 commented Jun 2, 2023

I believe this is related to a bug in gradio v3.31.0. Editing requirements.txt and requirements_versions.txt to change the gradio version to v3.33.1 has solved this issue for me, along with A1111 ignoring a custom temp directory and saving in C:\Users\[username]\AppData\Local\Temp\. I would raise a PR but I'm not sure if any other considerations are necessary before bumping the gradio version. I haven't noticed any issues yet.

@reicou
Copy link

reicou commented Jun 3, 2023

I believe this is related to a bug in gradio v3.31.0. Editing requirements.txt and requirements_versions.txt to change the gradio version to v3.33.1 has solved this issue for me, along with A1111 ignoring a custom temp directory and saving in C:\Users\[username]\AppData\Local\Temp\. I would raise a PR but I'm not sure if any other considerations are necessary before bumping the gradio version. I haven't noticed any issues yet.

This worked for me too, thanks so much for showing it :)

@sean-kang
Copy link

This issue has been fixed in the latest v1.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

9 participants