Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twisted tube: twisted angle unit conversion now works properly #1227

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DDCore/src/Shapes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ void EllipticalTube::make(const std::string& nam, double a, double b, double dz)
/// Internal helper method to support TwistedTube object construction
void TwistedTube::make(const std::string& nam, double twist_angle, double rmin, double rmax,
double zneg, double zpos, int nsegments, double totphi) {
_assign(new TwistedTubeObject(nam.c_str(), twist_angle, rmin, rmax, zneg, zpos, nsegments, totphi/units::deg),
_assign(new TwistedTubeObject(nam.c_str(), twist_angle/units::deg, rmin, rmax, zneg, zpos, nsegments, totphi/units::deg),
"", TWISTEDTUBE_TAG, true);
}

Expand Down
Loading