Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overridden children's ids when cloning DetElement #605

Closed
sponce opened this issue Dec 20, 2019 · 2 comments · Fixed by #606
Closed

Overridden children's ids when cloning DetElement #605

sponce opened this issue Dec 20, 2019 · 2 comments · Fixed by #606
Labels
Fixed Problem is solved

Comments

@sponce
Copy link
Contributor

sponce commented Dec 20, 2019

I think there is a bug in the clone method of DetElement, here :

DD4hep/DDCore/src/DetectorInterna.cpp

Line 121 in 5bbbb8c

DetElement c = d.clone(obj->id, DetElement::COPY_PLACEMENT);

As you can see the id of all children are overriden to the one of the parent. I would rather keep them by replacing obj-> by d.
MarkusFrankATcernch added a commit to MarkusFrankATcernch/DD4hep that referenced this issue Jan 9, 2020
@MarkusFrankATcernch
Fix for issue AIDASoft#605
a48c18d
@MarkusFrankATcernch MarkusFrankATcernch mentioned this issue Jan 9, 2020
Merged
MarkusFrankATcernch added a commit that referenced this issue Jan 9, 2020
@MarkusFrankATcernch
Fix for issue #605
11e8bc6
@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Jan 24, 2020 •
edited
Loading

If this issue is solved, please close the issue.
Thanks!

@sponce
Copy link
Contributor Author

sponce commented Jan 27, 2020

I suppose it's fixed yes. Now may I ask why you did not just fix it, but kept a flag to be able to resurrect the bug ? Seems to me like an unneeded complication that can only lead to problems if ever someone activates it.

@sponce sponce closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed Problem is solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue https://github.com/AIDASoft/DD4hep/issues/605 MarkusFrankATcernch/DD4hep
2 participants
@sponce @MarkusFrankATcernch