Trapezoid is represented as Trd2. What about Trd1?

[ianna]

CMS uses Trd1 and its divisions in Y (top snapshot). Currently it is translated to DD4hep as a Trapezoid == a TGeoTrd2 which is divisible only in Z (bottom snapshot).

*** Shape csc:ME11PolycarbPanel_shape_0x7f20137d4500: TGeoTrd2 ***
    dx1 =    15.06500
    dx2 =    30.45000
    dy1 =     7.27000
    dy2 =     7.27000
    dz  =    81.00000
 Bounding box:
*** Shape csc:ME11PolycarbPanel_shape_0x7f20137d4500: TGeoBBox ***
    dX =    30.45000
    dY =     7.27000
    dZ =    81.00000
    origin: x=    0.00000 y=    0.00000 z=    0.00000

[MarkusFrankATcernch]

Acknowledged.
I will add the corresponding shape constructor.
Any preference in the constructor signature ?
If not I hall take the ROOT signature.

[ianna]

I think, this is a usual Trd1:

  <Trd1 name="MECU_1_ME11Layer" dz="81*cm " dy1="[ME11CuFoilHalfThick]" dy2="[ME11CuFoilHalfThick]" dx1="15.065*cm " dx2="30.45*cm "/>

[MarkusFrankATcernch]

This is what TGeo calls a Trd2:
TGeoTrd2(Double_t dx1, Double_t dx2, Double_t dy1, Double_t dy2, Double_t dz)
A Trd1 for them is as follows:
TGeoTrd1(Double_t dx1, Double_t dx2, Double_t dy, Double_t dz)

Is this what you meant?

[MarkusFrankATcernch]

Hi Yana,
please have a look at: #461
... and close the issue if this is what you were looking for.

[ianna]

This is strange dY seems to be the same, but Trd1 is twice thinner in Y:

*** Shape csc:ME11PolycarbPanel_shape_0x7f1dd1892800: TGeoTrd1 ***
    dx1 =    15.06500
    dx2 =    30.45000
    dy  =     7.27000
    dz  =    81.00000
 Bounding box:
*** Shape csc:ME11PolycarbPanel_shape_0x7f1dd1892800: TGeoBBox ***
    dX =    30.45000
    dY =     7.27000
    dZ =    81.00000
    origin: x=    0.00000 y=    0.00000 z=    0.00000

[MarkusFrankATcernch]

"""This is strange dY seems to be the same, but Trd1 is twice thinner in Y:"""

Compared to what ?
I re-checked and I pass the values directly as they are to the TGeoTrd1 constructor.
TGeoTrd1 takes half lengths in x,y,z.
Is this effect originating from the raw constructor or the result of the division?

[ianna]

Fixed in our code. Thanks, @MarkusFrankATcernch !