Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtilityApps do not respect the BUILD_TESTING=OFF configuration flag #407

Closed
gordonwatts opened this issue Jun 19, 2018 · 0 comments · Fixed by #408
Closed

UtilityApps do not respect the BUILD_TESTING=OFF configuration flag #407

gordonwatts opened this issue Jun 19, 2018 · 0 comments · Fixed by #408

Comments

@gordonwatts
Copy link

Two programs in UtilityApps in the master require DDTest (test_surfaces and test_cellid_position_converter). However, if you issue a cmake command with BUILD_TESTING=OFF as an argument, the DDTest library is not built. Which means it can't be found by cmake, and the config step fails.

This needs to be surrounded by an if statement. Perhaps against BUILD_TESTING. If that is the proper variable to check, I'm happy to submit a pull request. If so, let me know what branch it should be against. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants