Skip to content

Commit 61c686e

Browse files
committed
Nette\DI\Statement are allowed for options base_path and base_urls
1 parent c67c5ce commit 61c686e

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/DI/Config.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ private function validatePackage(array $package, bool $isDefault): array
9090
Nette\Utils\Validators::assertField($package, 'version', 'string|null');
9191
Nette\Utils\Validators::assertField($package, 'version_format', TRUE === $isDefault ? 'string' : 'string|null');
9292
Nette\Utils\Validators::assertField($package, 'json_manifest_path', 'string|null');
93-
Nette\Utils\Validators::assertField($package, 'base_path', 'string|null');
94-
Nette\Utils\Validators::assertField($package, 'base_urls', 'string|string[]');
93+
Nette\Utils\Validators::assertField($package, 'base_path', 'string|null|' . Nette\DI\Statement::class);
94+
Nette\Utils\Validators::assertField($package, 'base_urls', 'string|string[]|' . Nette\DI\Statement::class . '[]');
9595

96-
if (is_string($package['base_urls'])) {
96+
if (!is_array($package['base_urls'])) {
9797
$package['base_urls'] = [ $package['base_urls'] ];
9898
}
9999

src/DI/PackageDefinitionFacade.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ public function __construct(ReferenceFacade $referenceFacade)
2323
}
2424

2525
/**
26-
* @param string $name
27-
* @param string|NULL $basePath
28-
* @param array $baseUrls
29-
* @param \Nette\DI\Statement $versionStrategy
26+
* @param string $name
27+
* @param string|NULL|\Nette\DI\Statement $basePath
28+
* @param array $baseUrls
29+
* @param \Nette\DI\Statement $versionStrategy
3030
*
3131
* @return \Nette\DI\Statement
3232
*/
33-
public function createPackageStatement(string $name, ?string $basePath, array $baseUrls, Nette\DI\Statement $versionStrategy): Nette\DI\Statement
33+
public function createPackageStatement(string $name, $basePath, array $baseUrls, Nette\DI\Statement $versionStrategy): Nette\DI\Statement
3434
{
3535
if (!empty($basePath) && !empty($baseUrls)) {
3636
throw new \LogicException('An asset package cannot have base URLs and base paths.');
@@ -39,7 +39,7 @@ public function createPackageStatement(string $name, ?string $basePath, array $b
3939
if (empty($baseUrls)) {
4040
$reference = $this->getPackageDependencyReference(
4141
new Nette\DI\Statement(Symfony\Component\Asset\PathPackage::class, [
42-
'basePath' => (string) $basePath,
42+
'basePath' => $basePath ?? '',
4343
'versionStrategy' => $versionStrategy,
4444
]),
4545
$name

0 commit comments

Comments
 (0)