Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conditional rendering in React Router #882

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Jan 30, 2025

Closes #881.

Should fail on all react-router based frameworks.
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 0:26am

For some reason the initial values aren't returned from useSearchParams
when mounting components after initial page load, unless you fill those up
as the `defaultInit` argument.
Copy link

pkg-pr-new bot commented Jan 30, 2025

Open in Stackblitz

npm i https://pkg.pr.new/nuqs@882

commit: 4d50df6

@franky47 franky47 marked this pull request as ready for review January 30, 2025 09:40
@franky47 franky47 merged commit 7f1b18a into next Jan 30, 2025
27 checks passed
@franky47 franky47 deleted the fix/881-rr-conditional-rendering branch January 30, 2025 12:56
Copy link

🎉 This PR is included in version 2.3.2-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 1, 2025

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 mentioned this pull request Feb 1, 2025
@franky47 franky47 removed this from the 🚀 Shipping next milestone Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale values when accessing useQueryState in conditional components
1 participant