[feat] add optional versioning id for s3 archive #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds file versioning for
s3_archive
in order to solve the problem defined belowConsider the following problem:
if person A updates the object in the s3 bucket, it will break person's B code since s3 archive now points at the new object. with this versioning enabled, we could update the object, but not break person B's code
The
file_version
field can be added to s3_archive if the s3 bucket is versionedresolves #3
Testing:
Sample error message if version id is invalid