Skip to content

Upgrade rusqlite and deadpool #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mirko-von-Leipzig opened this issue Jan 28, 2025 · 10 comments
Closed

Upgrade rusqlite and deadpool #649

Mirko-von-Leipzig opened this issue Jan 28, 2025 · 10 comments
Assignees
Milestone

Comments

@Mirko-von-Leipzig
Copy link
Collaborator

Follow-up from #642.

rusqlite upgrade is currently blocked by deadpool. I'd suggest subscribing to deadpool release notifications (I have done so).

@Mirko-von-Leipzig
Copy link
Collaborator Author

This is now unblocked - turns out deadpool does not use github releases so there was no notification 🙃

@TomasArrachea
Copy link
Collaborator

TomasArrachea commented Mar 6, 2025

I am having this dependency error when upgrading:

error: failed to select a version for `libsqlite3-sys`.
    ... required by package `rusqlite v0.32.1`
    ... which satisfies dependency `rusqlite = "^0.32.1"` of package `rusqlite_migration v1.3.0`
    ... which satisfies dependency `rusqlite_migration = "^1.3"` of package `miden-node-store v0.8.0 (/Users/tomas/Lambda/miden-node/crates/store)`
    ... which satisfies path dependency `miden-node-store` (locked to 0.8.0) of package `miden-node v0.8.0 (/Users/tomas/Lambda/miden-node/bin/node)`
versions that meet the requirements `^0.30.1` are: 0.30.1

the package `libsqlite3-sys` links to the native library `sqlite3`, but it conflicts with a previous package which links to `sqlite3` as well:
package `libsqlite3-sys v0.31.0`
    ... which satisfies dependency `libsqlite3-sys = "^0.31.0"` of package `rusqlite v0.33.0`
    ... which satisfies dependency `rusqlite = "^0.33"` of package `miden-node-store v0.8.0 (/Users/tomas/Lambda/miden-node/crates/store)`
    ... which satisfies path dependency `miden-node-store` (locked to 0.8.0) of package `miden-node v0.8.0 (/Users/tomas/Lambda/miden-node/bin/node)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the `links = "sqlite3"` value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

I am not sure but I think maybe it's still blocked by rusqlite_migration, here:
https://github.com/cljoly/rusqlite_migration/blob/19de4bfa8a1d2b02fdcf9ca177b31a62e534e694/rusqlite_migration/Cargo.toml#L44

@polydez
Copy link
Contributor

polydez commented Mar 14, 2025

This issue was resolved in #728.

@TomasArrachea
Copy link
Collaborator

deadpool was upgraded, but I think the rusqlite version is still at "0.32", right? Current rusqlite version is 0.34.

@polydez
Copy link
Contributor

polydez commented Mar 14, 2025

@TomasArrachea once the PR is merged, there will no deadpool-sqlite anymore, so we will be able to upgrade it without conflicts.

@TomasArrachea
Copy link
Collaborator

Ok, so you mean that we will be able to upgrade rusqlite once there is no more deadpool-sqlite? In that case I think we should reopen the issue and, in a separate PR, upgrade rusqlite.

@polydez
Copy link
Contributor

polydez commented Mar 14, 2025

Totally agree, I think, we closed the issue too early. @Mirko-von-Leipzig could you please reopen the issue?

@polydez
Copy link
Contributor

polydez commented Mar 14, 2025

@TomasArrachea I tried to update rusqlite and now it conflicts with rusqlite_migration. So the latest version of rusqlite we can use now is 0.32.1.

@TomasArrachea
Copy link
Collaborator

Ok, then this remains blocked until rusqlite_migration is updated.

@bobbinth
Copy link
Contributor

bobbinth commented Apr 3, 2025

Closing this as superseded by #773.

@bobbinth bobbinth closed this as completed Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants