Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the
submit_transaction
andsubmit_transaction_with_prover
calls exposed via WASM in the web client to justsubmit_transaction
.I made this change because in #720, I tried making it so that the top-level
WebClient
wrapper that I introduced to allow the web workers work only exposed onesubmit_transaction
call with an optional prover. Then, depending on whether aprover
was passed, it would call intosubmit_transaction
orsubmit_transaction_with_prover
as both of these calls were exposed from the rust side. The result of this could be confusing for consumers of the SDK because despite trying to consolidate the calls at the top level, the Typescript typings would still indicate thatsubmit_transaction_with_prover
is callable directly.As a result, I decided to consolidate the calls at the rust level, and fix the JS accordingly. Now there should be no confusion when calling
submit_transaction
as the it's the only call to make and the parameters are very clear.