fix: Avoid clippy bug #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
added
the
no changelog
tomyrd
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
With the --allow clippy::needless_return I don't think it's necessary to remove the semicolons.
bobbinth
approved these changes
Sep 26, 2024
igamigo
added a commit
that referenced
this pull request
Nov 7, 2024
* fix: Avoid clippy bug * Update build.rs * Update build.rs * re-add colon * re-add colon
igamigo
added a commit
that referenced
this pull request
Nov 7, 2024
* fix: Avoid clippy bug * Update build.rs * Update build.rs * re-add colon * re-add colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily avoids this bug
Also updates some deprecated prost code and changes the doc within the known script roots mod which were valid clippy warnings.