Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Sparse Merkle tree implementations #7

Closed
9 tasks done
Tracked by #32 ...
bobbinth opened this issue Oct 25, 2022 · 0 comments
Closed
9 tasks done
Tracked by #32 ...

Tracking issue: Sparse Merkle tree implementations #7

bobbinth opened this issue Oct 25, 2022 · 0 comments
Assignees
Milestone

Comments

@bobbinth
Copy link
Contributor

bobbinth commented Oct 25, 2022

Goal

We should add implementations of Sparse Merkle tree.

Details

Specifically, I'm thinking of the following variants:

  • Simple SMT (could go into /merkle/simple_smt.rs module).
  • Compact SMT (could go into /merkle/compact_smt.rs module).

References:

NICE TO HAVE

Preview Give feedback
No tasks being tracked yet.

Working group:

@Al-Kindi-0, @bobbinth, @grjte, @vlopes11, @hackaugusto

Workflow
  • Discussion should happen here or in the related sub-issues.
  • PRs should only be merged by the coordinator, to ensure everyone is able to review.
  • Aim to complete reviews within 24 hours.
  • When a related sub-issue is opened:
    • add it to the list of sub-issues in this tracking issue
  • When opening a related PR:
    • request review from everyone in this working group
  • When a sub-issue is completed:
    • close the related issue with a comment that links to the PR where the work was completed

Coordinator: @vlopes11

Workflow

The working group coordinator ensures scope & progress tracking are transparent and accurate. They will:

  • Merge approved PRs after all working group members have completed their reviews.
    • add the PR # to the relevant section of the current tracking PR.
    • close any completed sub-issue(s) with a comment that links to the PR where the work was completed
  • Monitor workflow items and complete anything that slips through the cracks.
  • Monitor scope to see if anything is untracked or unclear. Create missing sub-issues or initiate discussion as required.
  • Monitor progress to see if there's anything which isn't moving forward. Initiate discussion as required.
  • Identify PRs with especially significant changes and add @grjte and @bobbinth for review.
@grjte grjte changed the title Add Sparse Merkle tree implementations Tracking issue: Sparse Merkle tree implementations Dec 1, 2022
@grjte grjte moved this to Todo in Milestone for 2023/02 Dec 15, 2022
@grjte grjte moved this from Todo to In Progress in Milestone for 2023/02 Dec 15, 2022
@grjte grjte added this to the Testnet milestone Feb 23, 2023
@grjte grjte moved this to In Progress in Milestone for 2023/03/28 Feb 23, 2023
@bobbinth bobbinth mentioned this issue Mar 1, 2023
5 tasks
@grjte grjte moved this to In Progress in Milestone for 2023/05/31 Apr 18, 2023
@bobbinth bobbinth moved this from In Progress to Done in Milestone for 2023/05/31 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Status: Done
Development

No branches or pull requests

5 participants