We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word
Currently Word is a type alias
crypto/src/lib.rs
Lines 24 to 34 in 0c242d2
However, it is a critical component of our stack as it is used everywhere, in different forms. One example is RpoDigest:
RpoDigest
crypto/src/hash/rpo/digest.rs
Lines 7 to 11 in 0c242d2
They both have the same structure, but different concrete types. This leads to many cases where unsafe optimizations are required, such as in here:
#58
One of the problems highlighted by this PR is the need to convert between Word and RpoDigest efficiently (i.e. without copying/allocating) & safely.
We could achieve major simplification if:
Rpo256
The text was updated successfully, but these errors were encountered:
@bobbinth should we include this on 0.6? It will clean the code quite a bit as we won't have to convert between the types anymore
Sorry, something went wrong.
Yes - let's do it!
MerkleStore
Digest
No branches or pull requests
Currently
Word
is a type aliascrypto/src/lib.rs
Lines 24 to 34 in 0c242d2
However, it is a critical component of our stack as it is used everywhere, in different forms. One example is
RpoDigest
:crypto/src/hash/rpo/digest.rs
Lines 7 to 11 in 0c242d2
They both have the same structure, but different concrete types. This leads to many cases where unsafe optimizations are required, such as in here:
#58
One of the problems highlighted by this PR is the need to convert between
Word
andRpoDigest
efficiently (i.e. without copying/allocating) & safely.We could achieve major simplification if:
Word
was a structRpo256
was aWord
The text was updated successfully, but these errors were encountered: