add a flag loader to allow flags to be set also via env vars #524
+266
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
approved these changes
Feb 28, 2025
Comment on lines
+43
to
+44
| rpcUrl, _ = flag_loader.GetRpcUrlFlagValue(cmd, false) | ||
| testPrivateHexKey, _ = flag_loader.GetPrivateKeyFlagValue(cmd, false) |
There was a problem hiding this comment.
nit: I know flag_loader.GetRpcUrlFlagValue(cmd, false) should not return any error but I would still check if the error returned is nil. Just in case the implementation changes in the future.
| @@ -0,0 +1,41 @@ | |||
| package flag_loader | |||
There was a problem hiding this comment.
nit: I would avoid passing a boolean to the function, as this makes the code harder to debug and maintain.
I'd for something like:
func getOptionalFlagValue(cmd *cobra.Command, flagName, envVarName string) *string {}
func getRequiredFlagValue(cmd *cobra.Command, flagName, envVarName string) (*string, error) {
// leverage getOptionalFlagValue
}
func GetRequiredRpcUrlFlagValue(cmd *cobra.Command) (*string, error) {}
func GetOptionalRpcUrlFlagValue(cmd *cobra.Command) *string {}
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #521
allows current commands that depend on
--rpc-urland--private-keyflags to be set via env varsETH_RPC_URLandPRIVATE_KEYrespectively.Testing
call any command that depends on
--rpc-urlor--private-keyreplacing the flag by the respective env var, the execution must happen exactly the same.example: