Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Set Money::SYMBOLS, Money::SEPARATORS and Money::DELIMITERS deprecation target to 3.2 #16

Closed
weppos opened this issue Jul 31, 2010 · 2 comments

Comments

@weppos
Copy link
Member

weppos commented Jul 31, 2010

I deprecated Money::SYMBOLS, Money::SEPARATORS and Money::DELIMITERS when I created Money::Currency in #4.

One major release passed after it (Money 3), I think we can consider to bump set the deprecation target to Money 3.2 (as set for the Bank class).

I'm attaching a patch for this. I'm also refactoring the small Deprecation "framework" so that we can use it elsewhere in Money. For instance, I need it in #14.

@weppos
Copy link
Member Author

weppos commented Jul 31, 2010

Here's the patch (along with 2 other commits).
http://github.com/weppos/money/compare/18caf7ad26...fea72b08

@semmons99
Copy link
Member

Looks good, I've merged your changes into trunk.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants